Sync Mac PerformerDetailView with iOS; fit artist images; focus Artists search#205
Merged
Conversation
…ts search iOS PerformerDetailView: switch the artist image hero from aspect-fill to aspect-fit so portrait shots are no longer cropped top/bottom, sizing the hero from each image's aspect ratio and capping it to the window height while still bleeding past the horizontal gutters. Mac PerformerDetailView: bring it in line with iOS - - header image carousel that pages through all images (swipe + hover arrows + tappable dots), 320pt, aspect-fit (no cropping) - iOS-style birth/death date and instrument formatting (all instruments, primary-first), fixing the "Trumpet"-only regression - typography-only BIOGRAPHY with a height-capped Read More (no box, no duplicated dates/instruments) and iOS-styled Learn More links - RECORDINGS section: drop the icon, match BIOGRAPHY heading, bordered sort pill moved off the far right, brand-styled role segmented, +/- accordions, and Year/Title/Album card order Artists tab: focus the search field whenever the Artists tab is selected. MacSearchBar gains an optional focus binding; ContentView posts a focusArtistSearch signal on tab change which ArtistsListView consumes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the macOS
PerformerDetailViewin line with iOS, fixes artist-image cropping on both platforms, and makes the Artists tab focus its search field on selection.iOS
Mac PerformerDetailView (sync with iOS)
Artists search focus
MacSearchBargains an optional focus binding.ContentViewposts afocusArtistSearchsignal whenever the Artists tab becomes selected (covers both the top tab control and the menu command).ArtistsListViewconsumes it and focuses the search field.Testing
xcodebuildof theApproachNoteMacscheme succeeds (macOS, code signing disabled).🤖 Generated with Claude Code